Skip to content

Conversation

pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp August 19, 2025 05:09
@ihomp
Copy link
Member

ihomp commented Aug 22, 2025

The code looks OK. @Anna15170221, please test in the local branch.

@Anna15170221
Copy link
Contributor

@ihomp for the /tokens page it works fine.
We implemented this function only there, right?
Not for all the pages where the filters are used

@ihomp ihomp merged commit 74ad0aa into Bithomp:main Aug 23, 2025
@ihomp
Copy link
Member

ihomp commented Aug 23, 2025

@ihomp for the /tokens page it works fine. We implemented this function only there, right? Not for all the pages where the filters are used

I was thinking to have it on all the pages where we have filters, but due to implementation, we will need separate ticket with the list of all pages where we need it, with the list of all the filters we want to show..

for nft search - it will be too much to show etc..

not a priority to show all of them, but at least to say that some filters are applied - would be nice. priority 4

@pandablue0809 pandablue0809 deleted the feat/541/show-active-filter-indicator-above-table branch August 24, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants